Fix specifying memory order in v2 arrays #2951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
|
this looks good! and my explanation from #2950 was wrong -- this has nothing to do with the global config, it's just buggy code (that i think I wrote). |
|
So I updated the test, and it now passes a bit more. But the check that the actual array data is F-order now fails, so it looks like the data still isn't (and never was) actually being written in F-order. More digging needed... |
dstansby
commented
Apr 3, 2025
github-actions
bot
removed
the
needs release notes
d-v-b
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2950
TODO:
docs/user-guide/*.rstchanges/